Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot resolve symbols for … : memmem #6

Open
Chimrod opened this issue Aug 9, 2023 · 1 comment
Open

Cannot resolve symbols for … : memmem #6

Chimrod opened this issue Aug 9, 2023 · 1 comment
Labels
forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system.

Comments

@Chimrod
Copy link

Chimrod commented Aug 9, 2023

Hello, I cannot link the code when using mingw / windows.

The function memmem is not implemented in mingw. The library compile fine, but when I want to build some code using it, there is an error in the linking stage.
@github-iron github-iron added the forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system. label Aug 10, 2023
@WardBrian WardBrian mentioned this issue Oct 2, 2023
Merged
jonahbeckford added a commit to diskuv/diskuv-opam-repository that referenced this issue Dec 10, 2023
@jonahbeckford
Patch base_bigstring_stubs.c for memmem
2319697 
Mitigate janestreet/base_bigstring#6
@jonahbeckford
Copy link
Contributor

This affects MSVC as well. For now, I'll use the opam-cross-windows patch in DkML, with the changes:

  1. static linkage so does not escape the scope of the stubs file
  2. a Windows preprocessor guard so can be used in Unix

ref: https://github.com/diskuv/diskuv-opam-repository/blob/231969744fdeb1e76f2f850079c3e0f0fd94fc1c/packages/base_bigstring/base_bigstring.v0.16.0/files/base_bigstring-v0.16.0.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Chimrod @github-iron @jonahbeckford