Skip to content

Commit

Permalink
Fix up some messages about sampling wiki links
Browse files Browse the repository at this point in the history
Signed-off-by: Tudor Brindus <tbrindus@janestreet.com>
  • Loading branch information
Xyene committed Oct 28, 2023
1 parent 0dece72 commit 79a3bba
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion core/collection_mode.ml
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ let param =
no_arg
~doc:
"Use stacktrace sampling instead of Intel PT. If Intel PT is not available, \
magic-trace will default to this."
magic-trace will default to this. For more info: https://magic.trace.org/w/b"
in
select_collection_mode ~extra_events ~use_sampling
;;
2 changes: 1 addition & 1 deletion src/callgraph_mode.ml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ let param =
" When magic-trace is running with sampling collection mode, this sets how it \
should reconstruct callstacks. The options are [lbr]/[lbr-no-stitch]/[dwarf]/[fp] \
or a sexp. Will default to [lbr] is available and [dwarf] otherwise. For more \
info: https://magic-trace.org/w/c"
info: https://magic-trace.org/w/b"
;;

let to_perf_record_args = function
Expand Down
4 changes: 2 additions & 2 deletions src/perf_tool_backend.ml
Original file line number Diff line number Diff line change
Expand Up @@ -295,13 +295,13 @@ module Recording = struct
| None, false ->
Core.eprintf
"Warning: [-callgraph-mode] is defaulting to [Dwarf] which may have high \
overhead and decoding time. For more info: https://magic-trace.org/w/c\n";
overhead and decoding time. For more info: https://magic-trace.org/w/b\n";
return (Some Callgraph_mode.Dwarf)
| None, true ->
Core.eprintf
"Warning: [-callgraph-mode] is defaulting to [Last_branch_record] which may \
lose data and has limited callstack depth. For more info: \
https://magic-trace.org/w/c\n";
https://magic-trace.org/w/b\n";
return (Some (Callgraph_mode.Last_branch_record { stitched = true }))
| Some (Last_branch_record _), false ->
Deferred.Or_error.error_string
Expand Down

0 comments on commit 79a3bba

Please sign in to comment.