Gracefully handle owee failures in Elf.addr_table #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xyene
approved these changes
Apr 28, 2022
magic-trace only really needs debug symbols to choose a snapshot symbol and to provide file and line numbers in the trace. Make it so that if debug symbols are missing, we disable dependent functionality and issue a warning. Fixes janestreet#191
|
I reworked this, please take another look. |
Xyene
reviewed
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Owee shouldn't have the ability to crash magic-trace. It's ~always preferably to not display debug info instead of crashing on users.