Give a good error message when waitpid raises #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xyene
reviewed
May 24, 2022
src/trace.ml
Outdated
| in | ||
| if Result.is_error waitpid_result | ||
| then | ||
| Core.eprintf "Warning: [perf] exited suspiciously quickly; it may have crashed.\n%!"; |
There was a problem hiding this comment.
Do we want to provide the waitpid_result in the message, for debugging purposes?
This behavior is best demonstrated by the report in janestreet#210, where perf crashed and that made magic-trace crash. Let's nudge people that perf may have crashed, instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This behavior is best demonstrated by the report in #210, where perf
crashed and that made magic-trace crash. Let's nudge people that perf
may have crashed, instead.
Fixes #210