Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protocol to URLs embedded in help text #220

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

shoffmeister
Copy link
Contributor

Having recognizable URLs inside the help text helps humans and terminal (auto-highlighting) tooling alike

Signed-off-by: Stefan Hoffmeister stefan.hoffmeister@econos.de

Having recognizable URLs inside the help text helps humans and terminal (auto-highlighting) tooling alike

Signed-off-by: Stefan Hoffmeister <stefan.hoffmeister@econos.de>
@shoffmeister
Copy link
Contributor Author

Before this patch, I was actually thinking that there were stray pixels in the help text.

image

Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

@Xyene Xyene merged commit 79c1b48 into janestreet:master Jun 15, 2022
@shoffmeister shoffmeister deleted the add-protocol-to-url branch June 15, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants