Added env var to forcibly disable perf dlfilter #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tudor pointed out the necessity of an environment variable to disable using `--dlfilter` with `perf script`. This is because on our systems, perf is only allowed to run as root and trace the kernel with certain flags which do not include `--dlfilter`. This environment variable will allow the user to forcibly disable `--dlfilter` to be able to still trace the kernel in these situations. Signed-off-by: Aaron Lamoreaux <alamoreaux@janestreet.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tudor pointed out the necessity of an environment variable to disable using
--dlfilterwithperf script. This is because on our systems, perf is only allowed to run as root and trace the kernel with certain flags which do not include--dlfilter. This environment variable will allow the user to forcibly disable--dlfilterto be able to still trace the kernel in these situations.