Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed regex bug in CBR event when flags includes space #239

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

Lamoreauxaj
Copy link
Contributor

magic-trace crashes on the added test case due to missing a space in the regex. This PR just fixes this.

@Lamoreauxaj Lamoreauxaj marked this pull request as draft July 1, 2022 17:11
@Lamoreauxaj Lamoreauxaj marked this pull request as ready for review July 1, 2022 17:29
magic-trace crashes on the added test case due to missing a space in the regex.
This PR just fixes this.

Signed-off-by: Aaron Lamoreaux <alamoreaux@janestreet.com>
Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Xyene Xyene merged commit 22f7d7d into janestreet:master Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants