Added ability to fuzzy find on line number based triggers #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature adds triggers of the format `addr:0xfffff` or `line:file.ml:99:15`. All triggers can be prefixed with either `symbol:`, `addr:`, or `line:`, but if none is given, it will default to a symbol if possible and otherwise parse it as a line number or address. There is no feature to allow our fuzzy finding to work with the new options, but it could be possible to implement fuzzy finding on files for example. Signed-off-by: Aaron Lamoreaux <alamoreaux@janestreet.com>
This feature adds the ability to specify trigger modes like `-trigger line:?` and `-trigger symbol:?` which will cause fzf to only shows files or functions respectively. If `-trigger ?` is passed, it will show both. However if the user selects a file, there is another prompt for them to select the source location to break on. Signed-off-by: Aaron Lamoreaux <alamoreaux@janestreet.com>
Lamoreauxaj
force-pushed
the
fzf_trigger_modes
branch
from
8581749
to
8a3af2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT: Rebased on #241.
This feature adds the ability to specify trigger modes like
-trigger line:?and-trigger symbol:?which will cause fzf to only shows files or functions respectively. If-trigger ?is passed, it will show both. However if the user selects a file, there is another prompt for them to select the source location to break on.