Demangle OCaml symbols #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClyveGassant
force-pushed
the
demangle-ocaml-symbols
branch
from
7a0811a
to
510f505
Compare
seliopou
reviewed
Jul 20, 2022
ClyveGassant
force-pushed
the
demangle-ocaml-symbols
branch
from
510f505
to
c6c4718
Compare
|
Thank you for the comments! I resolved them. I appreciate it. |
|
@seliopou ready for review if you have free time! |
hlian
reviewed
Jul 22, 2022
ClyveGassant
force-pushed
the
demangle-ocaml-symbols
branch
2 times, most recently
from
3a5ba05
to
a75cfdb
Compare
Xyene
reviewed
Jul 25, 2022
Xyene
reviewed
Jul 25, 2022
Xyene
reviewed
Jul 25, 2022
ClyveGassant
force-pushed
the
demangle-ocaml-symbols
branch
from
a75cfdb
to
8f27985
Compare
|
Could you please rebase to pick up ad91ae0, so we can kick off CI again? |
Signed-off-by: Clyve Gassant <cgassant@sas.upenn.edu>
ClyveGassant
force-pushed
the
demangle-ocaml-symbols
branch
from
8f27985
to
a81352a
Compare
|
@Xyene I completed your comment! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #82 by implementing the demangling parser from perf. I also included expect tests.