Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows/build.yml: download upx 3.96-2 from ftp.debian.org #252

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

hlian
Copy link
Contributor

@hlian hlian commented Jul 26, 2022

The old URL disappeared, but this new location appears to work (when I tested it on my personal GitHub repo's CI). I'm not sure how relevant the old comment about musl is -- I didn't investigate deeply. To cover all the bases, I tweaked the comment slightly to just indicate that we're not using the default Ubuntu UPX. I'm guessing the Debian package is just built differently from the Ubuntu equivalent, but, again, didn't investigate too deeply.

Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Xyene Xyene merged commit ad91ae0 into janestreet:master Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants