Add separate events output in sexp or binio format #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Istlemin
force-pushed
the
events-output
branch
2 times, most recently
from
61814f8
to
9df0af4
Compare
|
Would you please rebase this onto the latest master before I take a look? It looks like this PR is based on code from March. |
cgaebel
requested changes
Aug 7, 2022
Istlemin
force-pushed
the
events-output
branch
4 times, most recently
from
a92e286
to
aea473c
Compare
gretay-js
reviewed
Aug 18, 2022
cgaebel
requested changes
Aug 22, 2022
Istlemin
force-pushed
the
events-output
branch
from
7e023f6
to
2dd306c
Compare
|
LGTM. Would you please squash your changes into a single commit before I merge this? |
cgaebel
approved these changes
Aug 24, 2022
Signed-off-by: Fredrik Ekholm <fekholm@janestreet.com>
Istlemin
force-pushed
the
events-output
branch
from
7d444da
to
4ed0c71
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature adds the argument -events-output=FILENAME and -callstacks.
Magic trace will dump all events to the events-output file,
either in sexp or binio format depending on the suffix.
If the flag -callstacks is set, for every event the current callstack will
also be dumped, using a compression algorithm to reduce size.