Don't assume perf is still alive after sending it SIGTERM
#293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We caught this in practice with certain builds of `perf`. This code seems pretty fishy, and I'd like to look into it further later: it's not obvious to me why `waitpid` would raise if the PID no longer exists. I would have expected `perf` to still be an unreaped child at this point. But, we do have ~identical logic in ferrying ^C to `perf` in `src/trace.ml` too... Signed-off-by: Tudor Brindus <tbrindus@janestreet.com>
cgaebel
approved these changes
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We caught this in practice with certain builds of
perf.This code seems pretty fishy, and I'd like to look into it further later: it's not obvious to me why
waitpidwould raise if the PID no longer exists. I would have expectedperfto still be an unreaped child at this point.But, we do have ~identical logic in ferrying ^C to
perfinsrc/trace.mltoo...