Can't install on MAC #31
Labels
forwarded-to-js-devs
This report has been forwarded to Jane Street's internal review system.
Comments
|
full output: |
github-iron
added
the
forwarded-to-js-devs
|
Hey,
Thanks for the report. I'm copying Xavier, who works on our public release.
I see two errors in your output.
File "src/regex.ml", line 145, characters 25-46:
Warning 52: Code should not depend on the actual values of
this constructor's arguments. They are only for information
and may change in future versions. (See manual section 9.5)
Xavier, why do we have this warning enabled in the public release? I
see internally that we include 52 in `hardcoded_disabled_warnings`:
app/jenga-rules/src/compiler_config.ml
I am also up for enabling it internally in this library. I will fix
the resulting build errors if you show me how to produce them.
/Users/davidwong/Work/official_mina/_opam/lib/ocaml/version:1:1: error: expected unqualified-id
4.07.1
^
/Users/davidwong/Work/official_mina/_opam/lib/ocaml/version:3:3: error: invalid preprocessing directive
# The version string is the first line of this file.
^
Xavier, I'm going to defer to you on this one as well. It looks like a
syntax error in the opam metadata? Here's the github issue with the
full output:
#31
Wang
|
|
The warning issue is probably a red herring as I expect warnings to be non The |
|
Indeed we are on an old version... issue might resolve itself when we bump. Thanks! |
|
The proposed fix worked FWIW! (except it's Is removing that file going to break anything else btw :D? |
|
Indeed, copy/paste mistake; sorry for that. Given that the file used to be installed, I can imagine some tools |
facebook-github-bot
pushed a commit
to facebook/pyre-check
that referenced
this issue
Jul 22, 2021
Summary: While working on pulling `pyre-ast` in as a dependency, I noticed that our opamcake build is failing for package `re2`: https://www.internalfb.com/intern/sandcastle/log/?instance_id=457949769&step_id=4706069902&step_index=3&name=Build Apparently this is caused by a [known bug](janestreet/re2#31) in OCaml version < 4.12 on MacOS. As the linked page mentioned, it is unlikely that the patch will be backported to prior version of OCaml. The best workaround we have atm is to either upgrade to 4.12 (which may lead to a perf regression that needs to be investigated first), or remove the extra `version` file ourselves manually. This diff takes the latter approach which is easier to do atm. Reviewed By: pradeep90 Differential Revision: D29838284 fbshipit-source-id: c49a077accf31a930f974dd0c7a9775762709247
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey! I started getting this error that I didn't get previously:
I'm still investigating, I'm not sure if the error is on my side or not.
The text was updated successfully, but these errors were encountered: