Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require C99 mode for older GCC #62

Merged

Conversation

jonahbeckford
Copy link
Contributor

This PR avoids the following error on an older GCC 4.8.5:

#=== ERROR while compiling dune.3.15.0 ========================================#
# context     2.2.0~alpha0~20221228 | linux/x86_64 |  | git+https://github.com/ocaml/opam-repository.git
# path        /work/.ci/o/2.1.1/.opam-switch/build/dune.3.15.0
# command     /work/.ci/o/2.1.1/bin/ocaml boot/bootstrap.ml -j 1
# exit-code   2
# env-file    /work/.ci/o/log/dune-11998-d28a2a.env
# output-file /work/.ci/o/log/dune-11998-d28a2a.out
### output ###
# ocamlc -output-complete-exe -w -24 -g -o .duneboot.exe -I boot unix.cma boot/libs.ml boot/duneboot.ml
# ./.duneboot.exe -j 1
# cd _boot && /work/.ci/o/2.1.1/bin/ocamlopt.opt -c -g -I +threads spawn_stubs.c
# vendor/spawn/src/spawn_stubs.c: In function 'init_spawn_info':
# vendor/spawn/src/spawn_stubs.c:526:5: error: 'for' loop initial declarations are only allowed in C99 mode
# vendor/spawn/src/spawn_stubs.c:526:5: note: use option -std=c99 or -std=gnu99 to compile your code

OP: ocaml/dune#10423

Signed-off-by: Jonah Beckford <71855677+jonahbeckford@users.noreply.github.com>
@jonahbeckford jonahbeckford force-pushed the fix-no-require-c99-mode-for-gcc branch from 4a68fe0 to 5bfb139 Compare April 16, 2024 03:35
@rgrinberg rgrinberg merged commit fe3419b into janestreet:master Apr 16, 2024
1 check passed
emillon added a commit to emillon/dune that referenced this pull request Apr 16, 2024
Updated to a version that contains janestreet/spawn#62.

Signed-off-by: Etienne Millon <me@emillon.org>
emillon added a commit to emillon/dune that referenced this pull request Apr 16, 2024
Updated to a version that contains janestreet/spawn#62.

Signed-off-by: Etienne Millon <me@emillon.org>
emillon added a commit to ocaml/dune that referenced this pull request Apr 17, 2024
Updated to a version that contains janestreet/spawn#62.

Signed-off-by: Etienne Millon <me@emillon.org>
emillon added a commit to emillon/dune that referenced this pull request Apr 17, 2024
Updated to a version that contains janestreet/spawn#62.

Signed-off-by: Etienne Millon <me@emillon.org>
emillon added a commit to emillon/dune that referenced this pull request Apr 17, 2024
Updated to a version that contains janestreet/spawn#62.

Signed-off-by: Etienne Millon <me@emillon.org>
emillon added a commit to ocaml/dune that referenced this pull request Apr 17, 2024
Updated to a version that contains janestreet/spawn#62.

Signed-off-by: Etienne Millon <me@emillon.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants