Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Janet tests fail on S390x #1497

Closed
bkmgit opened this issue Sep 6, 2024 · 2 comments
Closed

Janet tests fail on S390x #1497

bkmgit opened this issue Sep 6, 2024 · 2 comments
Labels
bug This is not expected behavior, and needs fixing

Comments

@bkmgit
Copy link

bkmgit commented Sep 6, 2024

When building for Fedora Linux:

3/29 test/suite-buffer.janet   FAIL            0.04s   exit status 1
>>> LD_LIBRARY_PATH=/builddir/build/BUILD/janet-1.35.2-build/janet-1.35.2/redhat-linux-build/ UBSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 ASAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1 MESON_TEST_ITERATION=1 MSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 MALLOC_PERTURB_=5 /builddir/build/BUILD/janet-1.35.2-build/janet-1.35.2/redhat-linux-build/janet /builddir/build/BUILD/janet-1.35.2-build/janet-1.35.2/redhat-linux-build/../test/suite-buffer.janet
――――――――――――――――――――――――――――――――――――― ✀  ―――――――――――――――――――――――――――――――――――――
stderr:
Starting suite /builddir/build/BUILD/janet-1.35.2-build/janet-1.35.2/redhat-linux-build/../test/suite-buffer.janet...
✘ /builddir/build/BUILD/janet-1.35.2-build/janet-1.35.2/redhat-linux-build/../test/suite-buffer.janet:82: "buffer/push-uint16 big endian": false
✘ /builddir/build/BUILD/janet-1.35.2-build/janet-1.35.2/redhat-linux-build/../test/suite-buffer.janet:86: "buffer/push-uint16 little endian": false
✘ /builddir/build/BUILD/janet-1.35.2-build/janet-1.35.2/redhat-linux-build/../test/suite-buffer.janet:96: "buffer/push-uint32 big endian": false
✘ /builddir/build/BUILD/janet-1.35.2-build/janet-1.35.2/redhat-linux-build/../test/suite-buffer.janet:100: "buffer/push-uint32 little endian": false
✘ /builddir/build/BUILD/janet-1.35.2-build/janet-1.35.2/redhat-linux-build/../test/suite-buffer.janet:108: "buffer/push-float32 big endian": false
✘ /builddir/build/BUILD/janet-1.35.2-build/janet-1.35.2/redhat-linux-build/../test/suite-buffer.janet:112: "buffer/push-float32 little endian": false
✘ /builddir/build/BUILD/janet-1.35.2-build/janet-1.35.2/redhat-linux-build/../test/suite-buffer.janet:116: "buffer/push-float64 big endian": false
✘ /builddir/build/BUILD/janet-1.35.2-build/janet-1.35.2/redhat-linux-build/../test/suite-buffer.janet:120: "buffer/push-float64 little endian": false
Finished suite /builddir/build/BUILD/janet-1.35.2-build/janet-1.35.2/redhat-linux-build/../test/suite-buffer.janet in 0.021 seconds - 49 of 57 tests passed.

Full log https://kojipkgs.fedoraproject.org//work/tasks/3385/123023385/build.log

@bakpakin bakpakin added the bug This is not expected behavior, and needs fixing label Sep 6, 2024
@bakpakin
Copy link
Member

bakpakin commented Sep 6, 2024

Thanks @bkmgit , looked into it.

Looks as though we were using some union tricks to copy words and switch endianness rather than just use memcpy. Simplifying the code there and using memcpy fixes the issues. I've also added s390x to the possible values for os/arch and added it to our CI.

Fixed as of e9deec8, closing.

@bakpakin bakpakin closed this as completed Sep 6, 2024
@bkmgit
Copy link
Author

bkmgit commented Sep 8, 2024

@bakpakin Thanks for the quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This is not expected behavior, and needs fixing
Projects
None yet
Development

No branches or pull requests

2 participants