Improved various error messages when handling unexpected types. #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zevv
force-pushed
the
error-messages
branch
3 times, most recently
from
b14ce95
to
039903e
Compare
|
The pipe syntax for a type union may appear in other places in the code, but since the new message is very clear, I don't think this will cause more confusion. These error messages are certainly no worse - as far s64 vs. "64 bit signed integer", I don't mind either way but if we are going the route of having as simple, readable prose as possible for error messages, "64 bit signed integer" is definitely better. |
error: bad slot janet-lang#1, expected string|symbol|keyword|buffer, got ... error: bad slot janet-lang#1, expected a string, symbol, keyword or buffer, got ... bad s64 initializer: "donkey" can not convert string "donkey" to s64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In other places error message do not talk about "s64" but about "64 bit signed integer", would that be preferable here as well?