Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More portable method of installing janet.h -> janet/janet.h symlink #1164

Merged
merged 1 commit into from May 28, 2023

Conversation

dressupgeekout
Copy link
Contributor

The problem that #994 was trying to solve (the symlink should be a relative path and not absolute) doesn't actually require the use of the GNU-only -t/-T option to ln(1).

@sogaiu
Copy link
Contributor

sogaiu commented May 27, 2023

To spell things out a bit...

The original proposed change looks like it was [1]:

ln -sf -t '$(DESTDIR)$(INCLUDEDIR)' janet.h janet/janet.h

What's currently in the Makefile is:

ln -sf -T ./janet/janet.h '$(DESTDIR)$(INCLUDEDIR)/janet.h' || true #fixme bsd

So it looks like there was a change to the original at some point.

Doing some digging, came across this.

Perhaps @shassard and/or @LeviSchuck would be interested in this topic.


[1] Which did get committed.

@bakpakin bakpakin merged commit ac5f118 into janet-lang:master May 28, 2023
7 checks passed
@dressupgeekout dressupgeekout deleted the janet_h_symlink branch May 31, 2023 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants