Fix order in which *macro-lints* is set during expansion #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-chambers
force-pushed
the
macro-lints-fix
branch
from
227560e
to
c27262a
Compare
Previously, `*macro-lints*` was set after the `macroexpand1` fiber was resumed, rather than just before. And, `*macro-lints*` was never cleared. This behavior was typically fine since the main users of `compile` pass the same lint array repeatedly, and the first macro expansion (somewhere in boot.janet) never produces a lint. But, when compiling with a fresh lint array, if the first macro invocation produced a lint, the lint was always lost.
chris-chambers
force-pushed
the
macro-lints-fix
branch
from
c27262a
to
52d3470
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
*macro-lints*was set after themacroexpand1fiber was resumed, rather than just before. And,*macro-lints*was never cleared. This behavior was typically fine since the main users ofcompilepass the same lint array repeatedly, and the first macro expansion (somewhere in boot.janet) never produces a lint. But, when compiling with a fresh lint array, if the first macro invocation produced a lint, the lint was always lost.