Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and ascii-sort string escapes in peg #1216

Merged
merged 1 commit into from Jul 8, 2023

Conversation

sogaiu
Copy link
Contributor

@sogaiu sogaiu commented Jul 8, 2023

Some escape sequences were added to Janet in d6337e77. This PR is an attempt to update the PEG for Janet in test/suite-peg.janet.

As the number of items is increasing, it seemed prudent to sort the items to make maintenance easier (e.g. avoidance of duplicates, locating a particular item, etc.). The sorting order chosen was based on what was found via the ascii(7) man page.

In an attempt to reduce the amount of "backslashing", also changed the string delimiter to backtick.

@sogaiu sogaiu marked this pull request as ready for review July 8, 2023 08:57
Copy link
Member

@pepe pepe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bakpakin bakpakin merged commit 5437744 into janet-lang:master Jul 8, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants