Fix: make proc_get_status compliant to OS documentation.
#1403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discused over gitter, `WIFSIGNALED` macro must be checked before one uses the WTERMSIG macro. This change reflects that necessity and adds a final else clause which will panic if no status code could be determined.
llmII
changed the title
proc_get_status compliant to OS documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discused over gitter,
WIFSIGNALEDmacro must be checked before one uses theWTERMSIGmacro. This change reflects that necessity and adds a final else clause which will panic if no status code could be determined.Also relevant is information gathered by @sogaiu in question-about-WTERMSIG-in-janet.md.
The idea here (currently, though it could be changed) is to panic when an unknown status code is encountered, as well as comply to the
man 2 waitpiddocumentation.