Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign Thumbnails #208

Merged
merged 10 commits into from Aug 24, 2017
Merged

Redesign Thumbnails #208

merged 10 commits into from Aug 24, 2017

Conversation

aniabui
Copy link
Contributor

@aniabui aniabui commented Aug 21, 2017

This PR is based on #207.

@aniabui
Copy link
Contributor Author

aniabui commented Aug 21, 2017

@cyntss what are your thoughts on implementing the "more options" for each thumbnail. At the moment, when we click on the thumbnail, it is pinned to the top and when we click on the caret, the options appear. My question is, should we keep it as it is or should we get rid of the option of pinning to the top by 1-click and let all the options appear once the user clicks on the thumbnail (like in the picture below)? Or do you have any other ideas on how to deal with this problem?

image

Update: I have left the way it is, but changed the interface slightly. I am not sure if removing that feature is a good decision. This can always be changed once we decide to get rid of it.

image

@aniabui aniabui changed the title [WIP] Redesign Thumbnails Redesign Thumbnails Aug 22, 2017
@aniabui aniabui mentioned this pull request Aug 22, 2017
@cyntss
Copy link
Contributor

cyntss commented Aug 23, 2017

@aniabui I agree with you and think that leaving it would be the best option for the time being. The icons look very good btw!

@imobachgs imobachgs merged commit 9162965 into jangouts:redesign Aug 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants