Added Access-Control headers if CORS is enabled #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good for me -> merge. Don't remember why it was left out... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR here, let's hope I do it well :)
Without setting withCredentials to true on javascript XHR, CORS is disabled. I added that in the relevant part of the code.
But there is something strange as
By reading the code, I suspect that maybe the developer knew but removed references to withCredential for a purpose. Maybe I am missing something here but the MDN article on withCredential does not indicate any side-effect.
https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/withCredentials