Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replacing mobx with jotai #160

Merged
merged 5 commits into from
Sep 14, 2023
Merged

refactor: replacing mobx with jotai #160

merged 5 commits into from
Sep 14, 2023

Conversation

namchuai
Copy link
Contributor

@namchuai namchuai commented Sep 12, 2023

Fixes #51, #162

@jansonarqube

This comment has been minimized.

@louis-jan
Copy link
Contributor

Fixes #169

@jansonarqube

This comment has been minimized.

@jansonarqube
Copy link

jansonarqube bot commented Sep 13, 2023

Failed

  • 0.00% Security Hotspots Reviewed on New Code (is less than 100.00%)

Analysis Details

12 Issues

  • Bug 0 Bugs
  • Vulnerability 3 Vulnerabilities
  • Code Smell 9 Code Smells

Coverage and Duplications

  • Coverage 0.00% Coverage (0.00% Estimated after merge)
  • Duplications 0.00% Duplicated Code (2.50% Estimated after merge)

Project ID: janhq_jan_AYpD9dALNKTWc87tHFux

View in SonarQube

@namchuai namchuai marked this pull request as ready for review September 14, 2023 02:33
@namchuai namchuai merged commit d55a838 into main Sep 14, 2023
1 check failed
@namchuai namchuai deleted the replace-mobx-with-jotai branch September 14, 2023 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: switching between models got blank page
2 participants