-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: inference engine provider and accessibility #2470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7c8f7e9
to
7fb5548
Compare
7fb5548
to
b914301
Compare
767b06d
to
ec3196d
Compare
28 tasks
ec3196d
to
24677e4
Compare
3 tasks
ec3196d
to
4df4851
Compare
4df4851
to
9551996
Compare
d9c8ff8
to
bdd2d09
Compare
beed065
to
26711fd
Compare
26711fd
to
14a6746
Compare
namchuai
approved these changes
Mar 25, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This PR lets the frontend control the inference engine directly. It helps manage logic before UX constraints, making the user experience smoother without waiting for events later on.
Currently:
Event-Driven:
Pros:
Cons:
Updated:
Direct Request (Engine Provider):
Pros:
Cons:
The core package has been restructured to accommodate compatibility with both browser and Node.js environments. It now includes two main directories:
browser/index.ts
.node/index.ts
.Fixes Issues
Self Checklist
->