Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: app does not gracefully stop a model #2593

Merged
merged 1 commit into from
Apr 3, 2024
Merged

fix: app does not gracefully stop a model #2593

merged 1 commit into from
Apr 3, 2024

Conversation

louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Apr 3, 2024 •
edited
Loading

Describe Your Changes

This is to reduce the duplication of nitro-killing requests. One at a time

Noticed the same while using the context length slider.
Each numerical change during a single slide triggers a nitro kill.
This spam can lead to a limbo state where nitro is not stopped and time-out messages flood the logs.

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@github-actions github-actions bot added the type: bug Something isn't working label Apr 3, 2024
@louis-jan louis-jan force-pushed the fix/app-does-not-gracefully-stop-model branch 3 times, most recently from 4507bb1 to 7d0ec2c Compare April 3, 2024 05:59
@hiento09 hiento09 requested review from a team and removed request for urmauur, namchuai, Inchoker and Van-QA April 3, 2024 06:40
@louis-jan louis-jan force-pushed the fix/app-does-not-gracefully-stop-model branch from 7d0ec2c to c96211f Compare April 3, 2024 06:56
@Van-QA Van-QA merged commit d579d8a into dev Apr 3, 2024
4 checks passed
@Van-QA Van-QA deleted the fix/app-does-not-gracefully-stop-model branch April 3, 2024 15:22
@github-actions github-actions bot added this to the v0.4.11 milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namchuai namchuai namchuai approved these changes

Assignees

@louis-jan louis-jan

Labels
type: bug Something isn't working
Projects
None yet
Milestone
v0.4.11
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@louis-jan @namchuai @Van-QA