Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: good bye react-scroll-to-bottom #2769

Merged
merged 1 commit into from Apr 21, 2024

Conversation

namchuai
Copy link
Contributor

Describe Your Changes

  • Paritally remove react scroll to bottom.

Fixes Issues

  • Remove below error.
Screenshot 2024-04-21 at 17 42 10

Videos

Screen.Recording.2024-04-21.at.17.38.45.mov

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@namchuai namchuai requested a review from urmauur April 21, 2024 11:26
@namchuai namchuai requested a review from louis-jan April 21, 2024 11:26
@github-actions github-actions bot added the type: chore Maintenance, integration, packaging related label Apr 21, 2024
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@namchuai namchuai merged commit da6c648 into dev Apr 21, 2024
9 checks passed
@namchuai namchuai deleted the refactor/good-bye-react-scroll-to-bottom branch April 21, 2024 15:30
@github-actions github-actions bot added this to the v0.4.12 milestone Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore Maintenance, integration, packaging related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants