Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: validate max_token from context_length value #2870

Merged
merged 1 commit into from
May 6, 2024
Merged

fix: validate max_token from context_length value #2870

merged 1 commit into from
May 6, 2024

Conversation

urmauur
Copy link
Contributor

@urmauur urmauur commented May 6, 2024

Describe Your Changes

  • Validate max max_token from content_length

Fixes Issues

Screen.Recording.2024-05-06.at.14.50.32.mov
  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur added the type: bug Something isn't working label May 6, 2024
@urmauur urmauur self-assigned this May 6, 2024
@hahuyhoang411
Copy link
Contributor

LGTM cc @imtuyethan

@hahuyhoang411 hahuyhoang411 mentioned this pull request May 6, 2024
Merged
3 tasks
@Van-QA Van-QA merged commit a6ccd67 into dev May 6, 2024
9 checks passed
@Van-QA Van-QA deleted the fix/context-length branch May 6, 2024 08:10
@github-actions github-actions bot added this to the v0.5.0 Broken Rice milestone May 6, 2024
@Van-QA
Copy link
Contributor

Van-QA commented May 6, 2024

testing failed with a few issues below ❌

  1. local model: dragging ctx_len to 0, and the value of max_token is 128 ❌
    image
  2. remote model: max_token is NaN ❌
    image
    @urmauur

@Van-QA Van-QA self-requested a review May 6, 2024 08:46
@urmauur urmauur mentioned this pull request May 6, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hahuyhoang411 hahuyhoang411 hahuyhoang411 approved these changes

@namchuai namchuai Awaiting requested review from namchuai

@louis-jan louis-jan Awaiting requested review from louis-jan

@Van-QA Van-QA Awaiting requested review from Van-QA

Assignees

@urmauur urmauur

Labels
type: bug Something isn't working
Projects
Jan Project
Archived in project
Milestone
v0.4.13 🌾 Broken Rice
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urmauur @hahuyhoang411 @Van-QA