status fails to update after a successful build #19
Comments
|
The null URL when triggered is OK because when triggered the URL isn't known yet. |
|
Ok. I was throwing it out as something I noticed. If that's not relevant i Sent from my iPhone On Oct 20, 2012, at 20:16, "Honza Brázdil" notifications@github.com wrote: The null URL when triggered is OK because when triggered the URL isn't — |
|
Isn't there some stack trace in the log? Try to update to version 1.3.2 which have better logging and try it again. |
|
No, no stacktraces in the log at all unfortunately. I had to restart jenkins for a different reason and after the restart it now works fine. Though I still can't tell you why it was not working before. |
|
I spoke too soon. Restart fixed one of the repos, but it immediately stopped working again. I will update to 1.3.2 as soon as its available in the update center. |
|
I am also having this same issue. I updated to 1.3.2 and the first pull request I created worked but any new commits or new pull requests no longer work. Here is the console output: |
|
Also I did just find that if I comment in the pull request "ok to test" then the status updates correctly in GitHub. |
|
We have seen this to. |
|
I have the same problem. Sometimes it just doesnt update the status on github. This is log when its ok: Dec 7, 2012 6:21:05 PM org.jenkinsci.plugins.ghprb.GhprbRepo createCommitStatus INFO: Setting status of 9084f68671a36dea70674a838d00f1e73932feac to PENDING with url http://master-001.build.quantec-networks.de:8080/job/phoenixpilot-pull-request-builder/7/ and mesage: Merged build started. Dec 7, 2012 6:22:04 PM org.jenkinsci.plugins.ghprb.GhprbPullRequest check INFO: Pull request builder: pr #52 was updated 12/7/12 6:21 PM, is updated 12/7/12 6:21 PM Dec 7, 2012 6:22:04 PM org.jenkinsci.plugins.ghprb.GhprbPullRequest check INFO: Pull request was updated, but there isn't new comments nor commits. (But it may mean that commit status was updated) Dec 7, 2012 6:22:04 PM org.jenkinsci.plugins.ghprb.GhprbPullRequest check INFO: Pull request builder: pr #41 was updated 12/7/12 6:13 PM, is updated 12/7/12 6:21 PM Dec 7, 2012 6:22:04 PM org.jenkinsci.plugins.ghprb.GhprbPullRequest check INFO: Pull request was updated, but there isn't new comments nor commits. (But it may mean that commit status was updated) Dec 7, 2012 6:22:04 PM org.jenkinsci.plugins.ghprb.GhprbPullRequest check INFO: Pull request builder: pr #40 was updated 12/7/12 6:20 PM, is updated 12/7/12 6:21 PM Dec 7, 2012 6:22:04 PM org.jenkinsci.plugins.ghprb.GhprbPullRequest check INFO: Pull request was updated, but there isn't new comments nor commits. (But it may mean that commit status was updated) Dec 7, 2012 6:27:31 PM hudson.model.Run execute INFO: phoenixpilot-pull-request-builder #7 main build action completed: SUCCESS Dec 7, 2012 6:28:04 PM org.jenkinsci.plugins.ghprb.GhprbRepo createCommitStatus INFO: Setting status of 9084f68671a36dea70674a838d00f1e73932feac to SUCCESS with url http://master-001.build.quantec-networks.de:8080/job/phoenixpilot-pull-request-builder/7/ and mesage: Merged build finished. This is when it fails: Dec 7, 2012 6:28:04 PM org.jenkinsci.plugins.ghprb.GhprbRepo createCommitStatus INFO: Setting status of 5770cc0bb83cbbdd11f9bf6558f3bfcfd6b2a621 to PENDING with url http://master-001.build.quantec-networks.de:8080/job/phoenixpilot-pull-request-builder/8/ and mesage: Merged build started. Dec 7, 2012 6:29:04 PM org.jenkinsci.plugins.ghprb.GhprbPullRequest check INFO: Pull request builder: pr #52 was updated 12/7/12 6:21 PM, is updated 12/7/12 6:28 PM Dec 7, 2012 6:29:04 PM org.jenkinsci.plugins.ghprb.GhprbPullRequest check INFO: Pull request was updated, but there isn't new comments nor commits. (But it may mean that commit status was updated) Dec 7, 2012 6:29:04 PM org.jenkinsci.plugins.ghprb.GhprbPullRequest check INFO: Pull request builder: pr #40 was updated 12/7/12 6:21 PM, is updated 12/7/12 6:28 PM Dec 7, 2012 6:29:04 PM org.jenkinsci.plugins.ghprb.GhprbPullRequest check INFO: Pull request was updated, but there isn't new comments nor commits. (But it may mean that commit status was updated) Dec 7, 2012 6:34:52 PM hudson.model.Run execute INFO: phoenixpilot-pull-request-builder #8 main build action completed: SUCCESS |
|
I have the same problem on Jenkins 1.494 and plugin on version 1.4. Thats the output on the log: Anyone got a way to fix that? |
|
Have the same problem. Any ideas about how to fix it? |
|
same here, status won't update to success |
|
Same here on version 1.5. Nothing in the logs either. :-( |
|
Here is some logging I captured on version 1.5. (Domains and organization names have been changed for security) Not sure if this helps or not: |
|
What's interesting here, is that it looks like it's setting the commit status to pending after the build has completed (in my case successfully). The commit, I'm pretty sure, didn't have a status at all until the build finished. |
|
As the originator of this request. I just wanted to put out that we have not seen this behaviour in some time. |
|
I'll add that we are still seeing this issue. |
|
I'm seeing a problem that may be related - the pull request builder is building pull requests and the builds are successful, but the commits are being marked as FAILED. Once I was watching the real-time updates on the Github pull request page and I think I saw the commit status change to SUCCESS but then immediately change to FAILED, but I'm not sure. This seems to have started after updating to the plugin version 1.5.1 and updating Jenkins and the Github and Github API plugins to the latest version. I have attached a log. |
|
Github provides api for listing history of all statuses on commit: |
|
Hmm. So, it seems like in chronological order, the commit in question got:
Might be worth noting I've set the pull request builder to poll every minute. |
|
heh, OK - disregard the previous report. There were 2 Jenkins instances updating the same pull request and builds were failing on one of them, which explains the inconsistency. |
|
I apologize in advance if I have missed some simple fix, but I have been struggling with it for a few days already.
The logs: I have been trying to understand where this "pending" status gets retrieved from and have been checking github api for statuses, but the last status of the last commit is always success, and according to github docs it gets the last status of the commit to display. I would appreciate any help on this issue since nothing else worked for me. |
|
@MargaretKrutikova So nothing between the logs and the PR you posted are lining up for me. The sha in the logs doesn't match either of the ones you are posting from github. The ones from github don't even line up, the merged commit isn't the same as Test commit 25. Are you sure that is the only job that is running on this project? Please open a new issue also. |
|
True, my apology, that was a log from a different test build. This is the one from the screenshot: I will open a new issue then. |
|
Sorry for comment in this again. I have a similar problem. Anybody could give suggestion about this? |
|
I also experienced the same issue...my CI was saying SUCCESS but not updating GitHub. My solution was:
|
I have the builder working and it successfully builds pull requests for the organization (though manual builds continue to fail).
It successfully updates the pull request status when it starts to build. However, on completing the build successfully it fails to update the status. So the states remains ' Determining merge status — Merged build triggered' regardless that the build completed successfully.
Here is a bit of the log
The (perhaps) interesting bit is that the url in the triggered notification is null while the url in the success notification is a valid url
The text was updated successfully, but these errors were encountered: