Add type-definition #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarianoFndz
approved these changes
Nov 30, 2021
lib/api-get.js
Outdated
| class ApiGet extends API { | ||
|
|
||
| /** | ||
| * Validate the model, extracted from the parsed endpoint |
There was a problem hiding this comment.
🤔 Creo que falta el
* @returns {void}
Que usaste en el process .
Y de pasó en todos los metodos que no hay un return también se podría agregar. De esa manera quedan todos parejos.
There was a problem hiding this comment.
Como descripción le pondría:
"Realiza validaciones antes de procesar. Settea el Modelo a usar y parsea el Endpoint. Importante, no es aconsejable sobreescribirlo"
lib/api-get.js
Outdated
| /** | ||
| * @typedef {Object} ApiGetError A instance of APIGetError class | ||
| */ | ||
|
|
||
| class ApiGet extends API { |
There was a problem hiding this comment.
Este package quedó viejito.. aca podriamos exportarlo de una
module.exports = class ApiGet extends API {
lib/helpers/endpoint-parser.js
Outdated
| * @property {String} [parents] The rest of the text string that does not have a specific function | ||
| */ | ||
|
|
||
| /** |
There was a problem hiding this comment.
Esto deberia estar en el metodo no en la definición de la clase
gastonpereyra
requested changes
Dec 1, 2021
juanhapes
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requerimiento:
Se requiere agreagar estos TypeDef al package de API-Get
Historia de usuario
https://fizzmod.atlassian.net/browse/JCN-331
Subtarea
https://fizzmod.atlassian.net/browse/JCN-341