Optimized tests and full coverage

janis-commerce · Mar 26, 2021 · 1c5a907 · 1c5a907
1 parent e5ce870
commit 1c5a907
Show file tree

Hide file tree

Showing 16 changed files with 586 additions and 130 deletions.
diff --git a/lib/api-create.js b/lib/api-create.js
@@ -4,7 +4,7 @@ const { API } = require('@janiscommerce/api');
 
 const { Invoker } = require('@janiscommerce/lambda');
 
-const ClientFetcher = require('./helpers/client-model-fetcher');
+const ClientFetcher = require('./helpers/model-fetcher');
 const ModelFormatter = require('./helpers/model-formatter');
 
 module.exports = class ClientCreateAPI extends API {

diff --git a/lib/helpers/credentials-fetcher.js b/lib/helpers/credentials-fetcher.js
@@ -17,19 +17,13 @@ module.exports = class CredentialsFetcher {
 
 	static async fetch() {
 
-		if(this.secretValue)
-			return;
-
 		try {
 
-			console.log(this.secretName);
-
 			const secretHandler = AwsSecretsManager.secret(this.secretName);
 
 			this.secretValue = await secretHandler.getValue();
 
 		} catch(err) {
-			console.log(err);
 			this.secretValue = {};
 			// nothing to do here
 			// no explota en este punto así dejamos que algún Driver se conecte por contexto, sin credenciales

diff --git a/lib/helpers/client-model-fetcher.js → lib/helpers/model-fetcher.js b/lib/helpers/client-model-fetcher.js → lib/helpers/model-fetcher.js
diff --git a/lib/helpers/model-formatter.js b/lib/helpers/model-formatter.js
@@ -6,7 +6,7 @@ const replaceKeys = require('./replace-keys');
 
 const CredentialsFetcher = require('./credentials-fetcher');
 
-const ClientFetcher = require('./client-model-fetcher');
+const ClientFetcher = require('./model-fetcher');
 
 module.exports = class ModelFormatter {
 

diff --git a/lib/listener-created.js b/lib/listener-created.js
@@ -4,7 +4,7 @@ const { EventListener } = require('@janiscommerce/event-listener');
 
 const MongoDBIndexCreator = require('@janiscommerce/mongodb-index-creator');
 
-const ClientFetcher = require('./helpers/client-model-fetcher');
+const ClientFetcher = require('./helpers/model-fetcher');
 const ModelFormatter = require('./helpers/model-formatter');
 
 const mongoDBIndexCreator = new MongoDBIndexCreator();

diff --git a/lib/listener-removed.js b/lib/listener-removed.js
@@ -3,7 +3,7 @@
 const { EventListener } = require('@janiscommerce/event-listener');
 const Model = require('@janiscommerce/model');
 
-const ClientFetcher = require('./helpers/client-model-fetcher');
+const ClientFetcher = require('./helpers/model-fetcher');
 
 module.exports = class ClientRemovedListener extends EventListener {
 
@@ -13,7 +13,7 @@ module.exports = class ClientRemovedListener extends EventListener {
 
 	get model() {
 
-		if(this._model) {
+		if(!this._model) {
 			const ClientModel = ClientFetcher.get();
 			this._model = new ClientModel();
 		}

diff --git a/lib/listener-updated.js b/lib/listener-updated.js
@@ -3,7 +3,7 @@
 const { EventListener } = require('@janiscommerce/event-listener');
 const MicroserviceCall = require('@janiscommerce/microservice-call');
 
-const ClientFetcher = require('./helpers/client-model-fetcher');
+const ClientFetcher = require('./helpers/model-fetcher');
 
 module.exports = class ClientUpdatedListener extends EventListener {