Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix index #2

Merged
merged 3 commits into from
Apr 29, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .nycrc
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
".eslintrc.js",
".travis.yml",
"index.js",
"lib/client-model-indexes.js",
"lib/client-functions.js"
],
"extension": [
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ const { clientModelIndexes } = require('@janiscommerce/client-creator');
module.exports = {
core: {
//...ohter indexes
...clientModelIndexes
...clientModelIndexes()
}
};
```
Expand Down
2 changes: 1 addition & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
const APICreate = require('./lib/api-create');
const ModelClient = require('./lib/model-client');
const ListenerCreated = require('./lib/listener-created');
const clientFunctions = require('./lib/client-functions.json');
const clientFunctions = require('./lib/client-functions');
const clientModelIndexes = require('./lib/client-model-indexes');

module.exports = {
Expand Down
6 changes: 3 additions & 3 deletions lib/client-model-indexes.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@

const InstanceGetter = require('./helper/instance-getter');

const Client = InstanceGetter.getModelClass('client');

const codeUnique = {
name: 'code_unique',
key: { code: 1 },
unique: true
};

module.exports = {
[Client.table]: [codeUnique]
module.exports = () => {
const Client = InstanceGetter.getModelClass('client');
return { [Client.table]: [codeUnique] };
};
27 changes: 27 additions & 0 deletions tests/client-model-indexes.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
'use strict';

const assert = require('assert');
const mockRequire = require('mock-require');
const path = require('path');
const ClientModelIndexes = require('../lib/client-model-indexes');
const ClientModel = require('../lib/model-client');


const fakeClientPath = path.join(process.cwd(), 'models', 'client');

const codeUnique = {
name: 'code_unique',
key: { code: 1 },
unique: true
};

const clientIndex = { [ClientModel.table]: [codeUnique] };

describe('ClientModelIndexes', () => {

it('should return the client index object when required', () => {
mockRequire(fakeClientPath, ClientModel);
assert.deepStrictEqual(ClientModelIndexes(), clientIndex);
mockRequire.stop(fakeClientPath);
});
});