JCN-373-campos-opcionales #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/helpers/client-formatter.js
Outdated
Comment on lines
31
to
40
| if(!additionalFields) | ||
| return formattedClient; | ||
|
|
||
| additionalFields.forEach(field => { | ||
|
|
||
| if(client[field]) | ||
| formattedClient[field] = client[field]; | ||
| }); | ||
|
|
||
| return formattedClient; |
There was a problem hiding this comment.
Suggested change
| if(!additionalFields) | |
| return formattedClient; | |
| additionalFields.forEach(field => { | |
| if(client[field]) | |
| formattedClient[field] = client[field]; | |
| }); | |
| return formattedClient; | |
| if(additionalFields) { | |
| additionalFields.forEach(field => { | |
| if(client[field]) | |
| formattedClient[field] = client[field]; | |
| }); | |
| } | |
| return formattedClient; |
gastonpereyra
requested changes
Apr 25, 2022
gastonpereyra
approved these changes
Apr 26, 2022
jormaechea
requested changes
Apr 26, 2022
| additionalFields.forEach(field => { | ||
|
|
||
| if(client[field]) | ||
| formattedClient[field] = client[field]; |
There was a problem hiding this comment.
Ojo, si el campo en el cliente tiene un valor falsy (más que nada 0 o false) no los está guardando. Debería chequear algo como typeof client[field] !== 'undefined' o algo parecido..
Agreguemos estos casos en los tests para asegurarnos que no se rompa en una próxima versión!
lib/listener-updated.js
Outdated
|
|
||
| ClientModel.additionalFields.forEach(fieldName => { | ||
|
|
||
| if(updatedClient[fieldName]) |
There was a problem hiding this comment.
Acá está el mismo problema con los valores falsy..
lib/model-client.js
Outdated
| static async formatForCreate(clientCodes) { | ||
| /** | ||
| * Get additional fields | ||
| * @returns {undefined} returns undefined by default |
There was a problem hiding this comment.
Suggested change
| * @returns {undefined} returns undefined by default | |
| * @returns {string[]|undefined} returns undefined by default |
jormaechea
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LINK AL TICKET
https://fizzmod.atlassian.net/browse/JCN-373
LINK A LA HISTORIA
https://fizzmod.atlassian.net/browse/JCN-372
DESCRIPCIÓN DEL REQUERIMIENTO
Se necesita que se puedan guardar (es decir crear o actualizar) datos extras propios del Cliente en JID.
Esto se debe hacer para que funcione en:
Logicamente actualizar el README con la nueva caracteristicas 😌
DESCRIPCIÓN DE LA SOLUCIÓN
postSaveHookya que puede ser util en futuros desarrollos.