fix getting a setting #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jormaechea
requested changes
Jun 4, 2020
tests/client-settings.js
Outdated
| limit: 1, | ||
| unique: true | ||
| }); | ||
| sinon.assert.calledTwice(ClientSettingsModel.prototype.getBy); |
There was a problem hiding this comment.
Ojo aca.. SI ya getteó las settings de una entidad de la DB, no debería ir de nuevo.. Esto estaba así pensando en que se guardaba un registro por entidad+setting, pero ahora que se guarda uno por entidad no debería ir de nuevo a la base por la misma entidad!
There was a problem hiding this comment.
corregido! ahora hace siempre 1 get, ya sea que busques una o mas settings, cachea todo
jormaechea
approved these changes
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Joaco, te hago el PR con el fix del
clientSetting.get()por si alguien quiere arrancar a usarlo, que funcione! y luego mejoramos lo de la case estatica!