New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JCN 320 cambiar guardado settings #5

Merged

manuelvilche merged 18 commits into master from JCN-320-Cambiar-guardado-settings

Mar 23, 2021

Contributor

gastonpereyra commented Mar 18, 2021

LINK AL TICKET
https://fizzmod.atlassian.net/browse/JCN-320

DESCRIPCIÓN DEL REQUERIMIENTO

Actualizar y mejorar el package https://github.com/janis-commerce/client-settings
Client-Settings debe estar actualizado
No debe usar un modelo de clients-settings
Debe usar el modelo de Clientes del servicio
Debe guardar las settings en cada cliente en la colección de clientes
Debe buscar esas settings donde corresponde
Actualizar Readme

DESCRIPCIÓN DE LA SOLUCIÓN
Se desarrollaron los requerimientos solicitado.
Se agrego un Cache con TTL para guardar temporalmente los settings

gastonpereyra added 10 commits

March 17, 2021 14:27


          Updated dependencies

ee0fc38


          Updated Schema Example

f5d5eac


          Delete Indexes and Model

4319c0e


          Change Get API

94f4688


          Updated Put Setting API

d6ed487


          Updated Tests

1a1d4b8


          Updated Client Settings

4af21ad


          Updated Changelog

4a54709


          Fixed README

27deda2


          Added Node-Cache TTL

a124a12

gastonpereyra added the enhancement label

gastonpereyra requested review from juanhapes, manuelvilche and KarenEchavarria

March 18, 2021 12:40

KarenEchavarria reviewed

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

KarenEchavarria reviewed

View reviewed changes

lib/client-settings.js Outdated Show resolved Hide resolved

KarenEchavarria reviewed

View reviewed changes

lib/get-setting-api.js Outdated Show resolved Hide resolved

KarenEchavarria reviewed

View reviewed changes

lib/put-setting-api.js Outdated Show resolved Hide resolved

KarenEchavarria reviewed

View reviewed changes

tests/get-setting-api.js Outdated Show resolved Hide resolved

KarenEchavarria reviewed

View reviewed changes

tests/get-setting-api.js Outdated Show resolved Hide resolved

KarenEchavarria reviewed

View reviewed changes

tests/put-setting-api.js Outdated Show resolved Hide resolved

KarenEchavarria reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

gastonpereyra added 5 commits

March 18, 2021 14:22


          Updated Changelog and Readme

12c5433


          Change format to use Reduce in API Get

4f9f777


          Added Set method for Cache Time

f2e538d


          Updated Put API


          Fixed Tests Descriptions

1194eed

gastonpereyra requested a review from KarenEchavarria

March 18, 2021 21:19

KarenEchavarria approved these changes

View reviewed changes

KarenEchavarria left a comment

Aprobado por mi parte, me pareció excelente que tomaras la iniciativa de agregar le método para settear el cache!

manuelvilche requested changes

View reviewed changes

docs/view-schemas/setting/edit.yml Show resolved Hide resolved

lib/client-settings.js Outdated Show resolved Hide resolved

lib/client-settings.js Outdated Show resolved Hide resolved

gastonpereyra added 2 commits

March 23, 2021 11:12


          Improved View-Schema example

af5f27e


          Improved Client Settings and changed Cache Time

3005fb1

gastonpereyra requested a review from manuelvilche

March 23, 2021 14:31

manuelvilche requested changes

View reviewed changes

docs/view-schemas/setting/edit.yml Show resolved Hide resolved


          Delete Source and Target in View Settings Example

2638ace

gastonpereyra requested a review from manuelvilche

March 23, 2021 14:51

manuelvilche approved these changes

View reviewed changes

manuelvilche merged commit 785e9d0 into master

manuelvilche deleted the JCN-320-Cambiar-guardado-settings branch

March 23, 2021 15:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment