Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event-Parser Package #1

Merged
merged 16 commits into from Aug 14, 2019
Merged

Event-Parser Package #1

merged 16 commits into from Aug 14, 2019

Conversation

deveplon
Copy link

@deveplon deveplon commented Aug 7, 2019

Descripción del requerimiento
Se requiere crear un parser para los eventos, con un modelo y el cual retorne los subscriptores

Cómo se puede probar?
Linkear el repo, crear la database que se quiere utilizar en local con la collection events o la que se le defina y dentro del mismo definir source, client, entity, event y subscribers como se muestra en la documentación, posterior a esto se pueden seguir los pasos de la documentación y ver que todo funcione como se espera.

lib/event-parser.js Outdated Show resolved Hide resolved
lib/event-parser.js Outdated Show resolved Hide resolved
lib/event-parser.js Outdated Show resolved Hide resolved
lib/model-event.js Show resolved Hide resolved
lib/model-event.js Outdated Show resolved Hide resolved
tests/event-parser-test.js Outdated Show resolved Hide resolved
tests/event-parser-test.js Outdated Show resolved Hide resolved
tests/event-parser-test.js Outdated Show resolved Hide resolved
tests/model-event-test.js Outdated Show resolved Hide resolved
tests/model-event-test.js Outdated Show resolved Hide resolved
@jormaechea jormaechea removed the request for review from juanhapes August 13, 2019 21:55
Copy link
Member

@jormaechea jormaechea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agregando el getter que te comenté, ya queda listo

lib/model-event.js Show resolved Hide resolved
Copy link
Member

@jormaechea jormaechea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jormaechea jormaechea merged commit 46ddf04 into janis-commerce:master Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants