Fixed assume role expiration validation

janis-commerce · May 12, 2020 · 55e9280 · 55e9280
1 parent 9a32c90
commit 55e9280
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/lib/log.js b/lib/log.js
@@ -159,7 +159,7 @@ class Log {
 
 		if(this.roleArn) {
 			firehoseParams.credentials = await this.getCredentials();
-			this._credentialsExpiration = firehoseParams.credentials.expiration;
+			this._credentialsExpiration = new Date(firehoseParams.credentials.expiration);
 		}
 
 		this._firehose = new Firehose(firehoseParams);

diff --git a/package-lock.json b/package-lock.json
diff --git a/tests/log-test.js b/tests/log-test.js
@@ -92,7 +92,7 @@ describe('Log', () => {
 			const fakeTime = sandbox.useFakeTimers(new Date().getTime());
 
 			sandbox.stub(STS.prototype, 'assumeRole')
-				.resolves({ ...fakeRole, Expiration: fakeTime.Date() });
+				.resolves({ ...fakeRole, Expiration: fakeTime.Date().toISOString() });
 
 			sandbox.stub(Firehose.prototype, 'putRecordBatch')
 				.resolves();
@@ -123,7 +123,7 @@ describe('Log', () => {
 			const fakeTime = sandbox.useFakeTimers(new Date().getTime());
 
 			sandbox.stub(STS.prototype, 'assumeRole')
-				.resolves({ ...fakeRole, Expiration: fakeTime.Date() });
+				.resolves({ ...fakeRole, Expiration: fakeTime.Date().toISOString() });
 
 			sandbox.stub(Firehose.prototype, 'putRecordBatch')
 				.resolves();
@@ -153,7 +153,7 @@ describe('Log', () => {
 			const fakeTime = sandbox.useFakeTimers(new Date().getTime());
 
 			sandbox.stub(STS.prototype, 'assumeRole')
-				.resolves({ ...fakeRole, Expiration: fakeTime.Date() });
+				.resolves({ ...fakeRole, Expiration: fakeTime.Date().toISOString() });
 
 			sandbox.stub(Firehose.prototype, 'putRecordBatch')
 				.resolves();
@@ -220,7 +220,7 @@ describe('Log', () => {
 			const fakeTime = sandbox.useFakeTimers(new Date().getTime());
 
 			sandbox.stub(STS.prototype, 'assumeRole')
-				.resolves({ ...fakeRole, Expiration: fakeTime.Date() });
+				.resolves({ ...fakeRole, Expiration: fakeTime.Date().toISOString() });
 
 			sandbox.stub(Firehose.prototype, 'putRecordBatch')
 				.throws();