JCN-266-assume-role-expiration #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LINK AL TICKET
https://fizzmod.atlassian.net/browse/JCN-266
DESCRIPCIÓN DEL REQUERIMIENTO
Se encontró un BUG en el cache interno de tiempo de expiración del AssumeRole
El error es que se esta comparando de la siguiente forma:
const hasExpired = this._credentialsExpiration < new Date();Cuando la variable
this._credentialsExpirationcontiene un ISOString como por ejemplo2020-05-12T15:58:47.031Z.DESCRIPCIÓN DE LA SOLUCIÓN
Se corrigió la validación de las fechas de expiración y se corrigieron los tests para que se pruebe correctamente esto.