Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JCN-273-correcciones-del-package #11

Merged
merged 1 commit into from May 15, 2020

Conversation

Nataniel4
Copy link
Contributor

LINK AL TICKET
https://fizzmod.atlassian.net/browse/JCN-273

DESCRIPCIÓN DEL REQUERIMIENTO
Se requiere arreglar el bug del método _add().

Se hace así… por este motivo no se ejecuta en este método.

try {
  return Promise.all();
} catch(e) {}

Se debe hacer así… para que se ejecute en este método y funcione el catch si se necesita.

try {
  await Promise.all();
} catch(e) {}

Mejorar los tests agregando el caso en que firehose falle pero se recupere antes de superar los reintentos y optimizar el codigo de los asserts.

DESCRIPCIÓN DE LA SOLUCIÓN
Se arreglo el problema con el catch y se mejoraron los tests

@Nataniel4 Nataniel4 requested a review from juanhapes May 15, 2020 19:26
@juanhapes juanhapes merged commit d9e7063 into master May 15, 2020
@jormaechea jormaechea deleted the JCN-273-correcciones-del-package branch January 10, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants