delete unnecessary try catchs

index.js

@@ -5,21 +5,15 @@
 const logger = require('./lib/colorful-lllog')();
 
 const MongodbIndexCreator = require('./lib/mongodb-index-creator');
-const MongodbIndexCreatorError = require('./lib/mongodb-index-creator-error');
 
 (async () => {
 
 	const mongodbIndexCreator = new MongodbIndexCreator();
 
-	try {
+	await mongodbIndexCreator.execute();
 
-		await mongodbIndexCreator.execute();
+	logger.info('Operation completed successfully.');
 
-		logger.info('Operation completed successfully.');
+	process.exit(0);
 
-		process.exit(0);
-
-	} catch(err) {
-		throw new MongodbIndexCreatorError(err.message, err.code);
-	}
 })();

lib/helpers/validate-indexes.js

@@ -1,6 +1,8 @@
 'use strict';
 
 const { struct } = require('superstruct');
+const MongodbIndexCreatorError = require('../mongodb-index-creator-error');
+
 
 const indexStruct = struct({
 	name: 'string',
@@ -20,8 +22,10 @@ module.exports = model => {
 	if(typeof model.constructor.indexes === 'undefined')
 		return;
 
-	if(!Array.isArray(model.constructor.indexes))
-		throw new Error(`Invalid indexes for collection ${model.constructor.table}: indexes must be an array of objects`);
+	if(!Array.isArray(model.constructor.indexes)) {
+		throw new MongodbIndexCreatorError(`Invalid indexes for collection ${model.constructor.table}: indexes must be an array of objects`,
+			MongodbIndexCreatorError.codes.INVALID_INDEXES);
+	}
 
 
 	try {
@@ -30,6 +34,7 @@ module.exports = model => {
 			.map(index => indexStruct(index));
 
 	} catch(err) {
-		throw new Error(`Invalid indexes for collection ${model.constructor.table}: ${err.message}`);
+		throw new MongodbIndexCreatorError(`Invalid indexes for collection ${model.constructor.table}: ${err.message}`,
+			MongodbIndexCreatorError.codes.INVALID_INDEXES);
 	}
 };

lib/mongodb-index-creator-error.js

@@ -16,8 +16,9 @@ module.exports = class MongodbIndexCreatorError extends Error {
 
 	static get codes() {
 		return {
+			CREATE_INDEX_ERROR: 1,
 			DROP_INDEX_ERROR: 2,
-			CREATE_INDEX_ERROR: 3
+			INVALID_INDEXES: 3
 		};
 	}
 };

lib/mongodb-index-creator.js

@@ -4,7 +4,6 @@ const logger = require('./colorful-lllog')();
 const serverlessFunction = require('./serverless-function');
 
 const { Client, ModelHelper, IndexHelper, Results } = require('./helpers');
-const MongodbIndexCreatorError = require('../lib/mongodb-index-creator-error');
 
 module.exports = class MongodbIndexCreator {
 
@@ -51,12 +50,8 @@ module.exports = class MongodbIndexCreator {
 		const models = modelHelper.getModels();
 
 		await Promise.all(models.map(model => {
-			try {
-				const indexHelper = new IndexHelper(model);
-				return indexHelper.process();
-			} catch(err) {
-				throw new MongodbIndexCreatorError(err.message, MongodbIndexCreatorError.codes.CREATE_INDEX_ERROR);
-			}
+			const indexHelper = new IndexHelper(model);
+			return indexHelper.process();
 		}));
 	}
 

tests/core-indexes-test.js

@@ -287,7 +287,7 @@ describe('MongodbIndexCreator - Core Indexes', () => {
 
 				sinon.spy(SimpleModel.prototype, 'createIndex');
 
-				await assert.rejects(() => execute(), {
+				await assert.rejects(execute(), {
 					code: MongodbIndexCreatorError.codes.DROP_INDEX_ERROR
 				});
 
@@ -359,9 +359,7 @@ describe('MongodbIndexCreator - Core Indexes', () => {
 				sinon.stub(InvalidIndexesModel.prototype, 'createIndex')
 					.resolves(true);
 
-				await assert.rejects(execute(), {
-					code: MongodbIndexCreatorError.codes.CREATE_INDEX_ERROR
-				});
+				await assert.rejects(execute(), { code: MongodbIndexCreatorError.codes.INVALID_INDEXES });
 
 				sinon.assert.notCalled(InvalidIndexesModel.prototype.getIndexes);
 				sinon.assert.notCalled(InvalidIndexesModel.prototype.dropIndex);