JCN-155-validacion-de-configuracion #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 10, 2019 17:56
tests/config-validator-test.js
Outdated
|
|
||
| }); | ||
|
|
||
| it('should throw invalid setting when a setting has an unexpected type', () => { |
There was a problem hiding this comment.
Se podrían chequear también las otras posibilidades de tipo de datos ya que hay strings y numbers
gastonpereyra
approved these changes
Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JCN-155-VALIDACION-DE-CONFIGURACION
JCN-155 Validación de configuración para construir el Driver
LINK AL TICKET
https://fizzmod.atlassian.net/browse/JCN-155
DESCRIPCIÓN DEL REQUERIMIENTO
4.1. Validar campos de configuración que se usan en el
constructor()4.2. Validar existencia, tipo de datos, etcs
4.3. Agregar nueva clase MongoDBConfigError para el error handling
4.4. Documentar la nueva funcionalidad.
4.5. 100% de código testeado.
DESCRIPCIÓN DE LA SOLUCIÓN
Se realizaron los requerimientos solicitados