Merge pull request #4 from janis-commerce/FIX-buffer-response-to-string

FIX - buffer response to string
janis-commerce · Aug 23, 2021 · 7d1cd66 · 7d1cd66
2 parents 8ab120f + d75225a
commit 7d1cd66
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/lib/request-response.js b/lib/request-response.js
@@ -42,7 +42,7 @@ module.exports = class RequestResponse {
 		try {
 			return JSON.parse(rawBody.toString());
 		} catch(error) {
-			return rawBody;
+			return rawBody.toString();
 		}
 	}
 };
diff --git a/tests/request.js b/tests/request.js
@@ -292,13 +292,15 @@ describe('Request Test', () => {
 
 		const url = 'http://test.com';
 
+		const bodyContent = '<h1>test</h1>';
+
 		const response = {
 			code: 200,
-			body: Buffer.from('<h1>test</h1>'),
+			body: Buffer.from(bodyContent),
 			headers: { 'content-type': 'text/html' }
 		};
 
-		const payload = Buffer.from('<form>test</form>', 'utf-8');
+		const payload = Buffer.from(bodyContent, 'utf-8');
 
 		const reqPassThrough = new PassThrough();
 		const writeSpy = sinon.spy(reqPassThrough, 'write');
@@ -319,8 +321,8 @@ describe('Request Test', () => {
 		});
 
 		assert.deepStrictEqual(Request.statusCode, response.code);
-		assert.deepStrictEqual(Request.responseBody, response.body);
-		assert.deepStrictEqual(reqResponse.rawBody, response.body);
+		assert.deepStrictEqual(Request.responseBody, bodyContent);
+		assert.deepStrictEqual(reqResponse.rawBody, payload);
 	});
 
 	it('Should make a get request by default', async () => {