JCN-432 Modificar get object para retornar buffer #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastonpereyra
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LINK AL TICKET
https://janiscommerce.atlassian.net/browse/JCN-431
DESCRIPCIÓN DEL REQUERIMIENTO
Se necesita actualizar el package de S3 para que al usar el método de getObject en la propiedad Body sea de tipo Buffer .
A raiz de la actualización al uso del SDK v3 de AWS, esta propiedad llega en formato Readable , este formato hace que todos los usos en Janis salgan mal generar todo tipo de errores.
DESCRIPCIÓN DE LA SOLUCIÓN
Se modificó el metodo
S3.getObjectpara que retorne un Buffer en el Body.También se agregó un método
S3.getObjectRawpara que funcione con la respuesta original.