New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JCN 313 actualizar package #6
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastonpereyra
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
labels
Nov 5, 2020
maguimarijuan
suggested changes
Nov 6, 2020
maguimarijuan
approved these changes
Nov 9, 2020
juanhapes
requested changes
Nov 10, 2020
lib/sls-api-file-list.js
Outdated
return { ...fileDataFormatted, url }; | ||
} | ||
|
||
async formatUrl(path, name) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Este formatUrl()
es 100% igual al del API Get
Aprovechemos para reutilizar!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LINK AL TICKET
https://fizzmod.atlassian.net/browse/JCN-313
DESCRIPCIÓN DEL REQUERIMIENTO
Actualmente el package https://github.com/janis-commerce/sls-api-upload permite subir un archivo a un bucket de S3, gettearlos individual y como listado, y borrarlos.
Pero no contiene hooks (como los de API-Save-Data), ni puede formatearse de manera custom y esto hace que su posibilidades de uso sean limitadas
Requerimiento:
postSaveHook
postValidateHook
, para todos las API que lo necesiten, que sirva para chequeos extras.formats
, para poder realizar modificaciones custom a los datos de los archivos cuando se necesitenDESCRIPCIÓN DE LA SOLUCIÓN
Para ver correctamente renderizado el README:
https://github.com/janis-commerce/sls-api-upload/blob/JCN-313-Actualizar-package/README.md