Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JCN 313 actualizar package #6

Merged
merged 21 commits into from Nov 10, 2020
Merged

JCN 313 actualizar package #6

merged 21 commits into from Nov 10, 2020

Conversation

gastonpereyra
Copy link
Contributor

@gastonpereyra gastonpereyra commented Nov 5, 2020

LINK AL TICKET
https://fizzmod.atlassian.net/browse/JCN-313

DESCRIPCIÓN DEL REQUERIMIENTO

Actualmente el package https://github.com/janis-commerce/sls-api-upload permite subir un archivo a un bucket de S3, gettearlos individual y como listado, y borrarlos.

Pero no contiene hooks (como los de API-Save-Data), ni puede formatearse de manera custom y esto hace que su posibilidades de uso sean limitadas

Requerimiento:

  • Crear los hooks faltantes en la API Post (Relation), es decir postSaveHook
  • Crear los hooks de postValidateHook, para todos las API que lo necesiten, que sirva para chequeos extras.
  • Agregar la posibilidad de tener nuevos formats, para poder realizar modificaciones custom a los datos de los archivos cuando se necesiten

DESCRIPCIÓN DE LA SOLUCIÓN

  • Se desarrollaron los requerimientos solicitados.
  • Se mejoró el README.
  • En la API de Listado se agregan métodos para agregar filtros y ordenamiento de manera mas limpia, y se cambió la forma de agregar la URL a los objetos
  • En las API de Listado y GET, se agregaron 2 formats, uno para los datos en general y uno especifico para la URL

Para ver correctamente renderizado el README:

https://github.com/janis-commerce/sls-api-upload/blob/JCN-313-Actualizar-package/README.md

@gastonpereyra gastonpereyra added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 5, 2020
CHANGELOG.md Outdated Show resolved Hide resolved
lib/sls-api-file-get.js Outdated Show resolved Hide resolved
lib/sls-api-file-list.js Show resolved Hide resolved
lib/sls-api-file-list.js Show resolved Hide resolved
lib/sls-api-file-list.js Outdated Show resolved Hide resolved
@maguimarijuan maguimarijuan self-requested a review November 9, 2020 14:29
return { ...fileDataFormatted, url };
}

async formatUrl(path, name) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Este formatUrl() es 100% igual al del API Get

Aprovechemos para reutilizar!

@juanhapes juanhapes merged commit ca7649a into master Nov 10, 2020
@juanhapes juanhapes deleted the JCN-313-Actualizar-package branch December 6, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants