Applied PR corrections

README.md

@@ -246,6 +246,7 @@ Removes a document in a solr core
 - model: `Model`: A model instance
 - item: `Object`: The item to be removed
 
+- Resolves `Boolean`: `true` if the operation was successful
 - Rejects `SolrError`: When something bad occurs
 
 ### ***async*** `multiRemove(model, filters)`
@@ -254,6 +255,7 @@ Removes one or more documents in a solr core
 - model: `Model`: A model instance
 - filters: `Object`: Filters criteria to match documents
 
+- Resolves `Boolean`: `true` if the operation was successful
 - Rejects `SolrError`: When something bad occurs
 
 ### ***async*** `createSchema(model, core)`
@@ -466,9 +468,11 @@ const model = new Model();
 
 	// remove
 	await solr.remove(model, { id: 'some-id', field: 'value' });
+	// > true
 
 	// multiRemove
 	await solr.multiRemove(model, { field: { type: 'greater', value: 10 } });
+	// > true
 
 	// createSchema
 	await solr.createSchema(model);

lib/config-validator.js

@@ -25,7 +25,7 @@ class ConfigValidator {
 
 			const validConfig = configStruct(config);
 
-			if((validConfig.user && !validConfig.password) || (validConfig.password && !validConfig.user))
+			if(validConfig.user && !validConfig.password)
 				throw new Error(`Password required for user '${validConfig.user}'`);
 
 			return validConfig;

lib/solr.js

@@ -172,6 +172,7 @@ class Solr {
 	 * Removes an item from the database
 	 * @param {Model} model Model instance
 	 * @param {Object} item The item to delete
+	 * @returns {Boolean} true if the operation was successful
 	 * @throws When something goes wrong
 	 * @example
 	 * await remove(model, { id: 'some-id', value: 'some-value' });
@@ -189,12 +190,15 @@ class Solr {
 		const res = await Request.post(endpoint, { delete: { id: item.id } }, this._auth);
 
 		Response.validate(res);
+
+		return true;
 	}
 
 	/**
 	 * Multi remove items from the database
 	 * @param {Model} model Model instance
 	 * @param {Object} filters solr filters
+	 * @returns {Boolean} true if the operation was successful
 	 * @throws When something goes wrong
 	 * @example
 	 * await multiRemove(model, { myField: { type: 'greater', value: 10 } });
@@ -212,6 +216,8 @@ class Solr {
 		const res = await Request.post(endpoint, query, this._auth);
 
 		Response.validate(res);
+
+		return true;
 	}
 
 	/**

tests/solr-test.js

@@ -131,8 +131,7 @@ describe('Solr', () => {
 			{ url: 'valid', core: 'valid', user: ['not a string'], password: 'valid' },
 			{ url: 'valid', core: 'valid', user: ['not a string'], password: ['not a string'] },
 			{ url: 'valid', core: 'valid', user: 'valid', password: ['not a string'] },
-			{ url: 'valid', core: 'valid', user: 'valid' },
-			{ url: 'valid', core: 'valid', password: 'valid' }
+			{ url: 'valid', core: 'valid', user: 'valid' }
 
 		].forEach(config => {