Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JCN-276-commit-config #6

Merged
merged 2 commits into from May 19, 2020
Merged

JCN-276-commit-config #6

merged 2 commits into from May 19, 2020

Conversation

Nataniel4
Copy link
Contributor

LINK AL TICKET
https://fizzmod.atlassian.net/browse/JCN-276

DESCRIPCIÓN DEL REQUERIMIENTO

  • commitUpdates: Boolean, default false. Este dato se debe enviar como commit={commitUpdates} en las requests de Endpoint update y updateCommands.
  • commitWithin: Number, default 10. Este dato se debe enviar como commitWithin={commitWithin} en las requests de Endpoint update y updateCommands.

Estas configuraciones deben estar disponibles para al crear la instancia Solr para ser configurable si así se desea.

DESCRIPCIÓN DE LA SOLUCIÓN
Se agregaron las configuraciones solicitadas y se mejoro el acceso a los codigos de error para facilitar el uso del driver

@Nataniel4 Nataniel4 requested a review from juanhapes May 19, 2020 13:26
@juanhapes juanhapes merged commit d642921 into master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastonpereyra gastonpereyra gastonpereyra approved these changes

@juanhapes juanhapes Awaiting requested review from juanhapes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Nataniel4 @gastonpereyra @juanhapes