JTR-116-fieldtypes #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -62,6 +56,45 @@ class Schema { | |||
| return schema.filter(({ name }) => !IGNORED_FIELDS.includes(name)); | |||
| } | |||
|
|
|||
| static _buildFieldTypesQuery(fieldTypes, currentFieldTypes) { | |||
|
|
|||
| fieldTypes = this._buildFieldTypes(fieldTypes); | |||
There was a problem hiding this comment.
❓
fieldTypessiempre llega?, siempre llega como objeto ?
Pregunto, porque no veo validación y como usas propiedades de Object.prototype como entries y por ahi si no llega bien ese dato se puede llegar a romper
There was a problem hiding this comment.
Lo mismo para currentFieldTypes, pero con array
There was a problem hiding this comment.
✔️
Ya vi que llegan siempre con el formato, correcto. Asi qu esta bien esta parte
lib/helpers/schema.js
Outdated
| const fieldsToAdd = this._difference(schema, currentSchemas); | ||
|
|
||
| const fieldsToReplace = this._difference(schema, fieldsToAdd) | ||
| .filter(field => !currentSchemas.some(currentField => this._areEqualObjects(currentField, field))); |
There was a problem hiding this comment.
🕵️
Es lo mismo, escrito diferente, pero talvés agrega claridad a quien lo vaya a leer a futuro.
Que te parece ?
Suggested change
| .filter(field => !currentSchemas.some(currentField => this._areEqualObjects(currentField, field))); | |
| .filter(field => currentSchemas.every(currentField => !this._areEqualObjects(currentField, field))); |
lib/solr.js
Outdated
Comment on lines
450
to
460
| let res; | ||
|
|
||
| try { | ||
|
|
||
| const res = await this.request.get(endpoint); | ||
| res = await this.request.get(endpoint); | ||
|
|
||
| } catch(err) { | ||
| throw err; | ||
| } | ||
|
|
||
| try { |
There was a problem hiding this comment.
El try/catch esta de más si no haces ningún proceso con eso
Sugiero :
const res = await this.request.get(endpoint);Si request.get falla, va a throwear como esta pasando ahora
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LINK AL TICKET
https://fizzmod.atlassian.net/browse/JTR-116
DESCRIPCIÓN DEL REQUERIMIENTO
ping()para arrojar un error en caso de falla.DESCRIPCIÓN DE LA SOLUCIÓN
Se realizaron los cambios solicitados