Session y struct #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1057049128
💛 - Coveralls |
jormaechea
requested changes
Jul 21, 2021
There was a problem hiding this comment.
Te deje algunos comentarios (más que nada typos y ajustes en el JSDoc).
Lo que sí falta, es documentar en el README. Hay que documentar tanto el struct, como el messageAttributes con janis-client que se debe mandar y que si se manda, vas a tener el this.session disponible en tu handler..
lib/sqs-handler.js
Outdated
| * @param {import('./sqs-consumer')} Consumer | ||
| * @param {SQSEvent} event | ||
| * @param {boolean} isBatch | ||
| * @returns {Promise} |
There was a problem hiding this comment.
Solo para dejar en claro que el valor al que resuelve va a ser ignorado...
Suggested change
| * @returns {Promise} | |
| * @returns {Promise<void>} |
tests/sqs-handler.js
Outdated
| sinon.assert.calledOnceWithExactly(ConditionalConsumer.prototype.setSession, { clientCode: 'fizzmodarg' }); | ||
| }); | ||
|
|
||
| it('Should pass the event by the consumer with the sessions are setted', async () => { |
There was a problem hiding this comment.
Suggested change
| it('Should pass the event by the consumer with the sessions are setted', async () => { | |
| it('Should pass the event to the consumer with the session set for each of them', async () => { |
tests/sqs-handler.js
Outdated
| sinon.assert.calledWithExactly(ConditionalConsumer.prototype.setSession.getCall(1), { clientCode: 'test' }); | ||
| }); | ||
|
|
||
| it('Should pass the event by the consumer with the sessions are setted and omit the session for the record without client', async () => { |
There was a problem hiding this comment.
Suggested change
| it('Should pass the event by the consumer with the sessions are setted and omit the session for the record without client', async () => { | |
| it('Should pass the event to the consumer with the sessions set only for the records with janis-client and omitted for the records without it', async () => { |
tests/sqs-handler.js
Outdated
| await assert.doesNotReject(SQSHandler.handle(ConditionalConsumerWithArrayStruct, eventWithoutClient)); | ||
| }); | ||
|
|
||
| it('Should throw error if the structure body in the records are not correct for a batch', async () => { |
There was a problem hiding this comment.
Suggested change
| it('Should throw error if the structure body in the records are not correct for a batch', async () => { | |
| it('Should reject if the body structure of the records are invalid when processing a batch', async () => { |
tests/sqs-handler.js
Outdated
| sinon.assert.calledWithExactly(ConditionalConsumer.prototype.setSession.getCall(1), { clientCode: 'test' }); | ||
| }); | ||
|
|
||
| it('Should process if the structure body in the records are correct', async () => { |
There was a problem hiding this comment.
Suggested change
| it('Should process if the structure body in the records are correct', async () => { | |
| it('Should process if the body structure in the records are valid', async () => { |
tests/sqs-handler.js
Outdated
| sinon.assert.notCalled(ConditionalConsumerWithStruct.prototype.processBatch); | ||
| }); | ||
|
|
||
| it('Should throw error if the structure body in the records are not correct at processing one by one', async () => { |
There was a problem hiding this comment.
Suggested change
| it('Should throw error if the structure body in the records are not correct at processing one by one', async () => { | |
| it('Should reject if the body structure of the records are invalid when processing one by one', async () => { |
added 3 commits
July 21, 2021 22:16
jormaechea
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Se agregaron dos puntos: