Añadir compatibilidad de componentes con styled components #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablonortiz
requested review from
colomfernando,
christian97dd,
pablodamianberdun,
dam788,
Maukr,
WilliamSaya-lvl30 and
GonzaFran
GonzaFran
approved these changes
Aug 16, 2023
Maukr
approved these changes
Aug 16, 2023
Pull Request Test Coverage Report for Build 5883190187
💛 - Coveralls |
pablodamianberdun
requested changes
Aug 16, 2023
pablodamianberdun
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LINK DE TICKET:
https://janiscommerce.atlassian.net/browse/JUIP-115
DESCRIPCIÓN DEL REQUERIMIENTO:
Contexto
Actualmente, al intentar utilizar el componente con styled components, al ser vinculado a alguna de las tres apps, esto no es posible
Necesidad
Se requiere hacer los componentes, que sean necesarios, compatibles para ser estilizados con styled components
DESCRIPCIÓN DE LA SOLUCIÓN:
Se le agregó la prop style a los componentes que sea posible editar los estilos para que, de esta manera, se los pueda estilizar con styled components
CÓMO SE PUEDE PROBAR?
Clonar e instalar el Repo de UI-Native
Linkear el componente con un proyecto, seguir la siguiente documentación
https://fizzmod.atlassian.net/wiki/spaces/JAPP/pages/2341765125/C+mo+trabajo+con+el+package+UI
Luego, se deberá probar que los distintos componentes modificados sean compatibles para editar con styled components