-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crear componente icon #22
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
63e35d6
crear componente icon
0825ecd
crear componente icon
f0b8253
crear componente icon
682ef98
pull master
919a118
correccion en crear componente icon
b52f4c1
pull master
9bdb477
agregar carpeta ios y android al build
0d4d6eb
pull de master
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,6 @@ | ||
rootProject.name = 'ui-native' | ||
apply from: file("../node_modules/@react-native-community/cli-platform-android/native_modules.gradle"); applyNativeModulesSettingsGradle(settings) | ||
include ':app' | ||
|
||
include ':react-native-vector-icons' | ||
project(':react-native-vector-icons').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-vector-icons/android') |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
module.exports = { | ||
dependencies: { | ||
'react-native-vector-icons': { | ||
platforms: { | ||
ios: null, | ||
}, | ||
}, | ||
}, | ||
}; |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
import React from 'react'; | ||
import Icon from './index'; | ||
import {create} from 'react-test-renderer'; | ||
|
||
describe('Icon component', () => { | ||
it('render correctly', () => { | ||
const {toJSON} = create(<Icon name="iso_janis" />); | ||
|
||
expect(toJSON()).toBeTruthy(); | ||
}); | ||
|
||
it('return null when name no exist', () => { | ||
const {toJSON} = create(<Icon name={''} />); | ||
|
||
expect(toJSON()).toBeNull(); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
import React, {FC} from 'react'; | ||
import {createIconSetFromIcoMoon} from 'react-native-vector-icons'; | ||
import icoMoonConfig from './assets/fonts/selection.json'; | ||
import {primary} from '../../theme/palette'; | ||
|
||
const IconComponent = createIconSetFromIcoMoon( | ||
icoMoonConfig, | ||
'janis-font-icon', | ||
'janis-font-icon.ttf' | ||
); | ||
|
||
interface Props { | ||
name: string; | ||
color?: string; | ||
size?: number; | ||
} | ||
|
||
const Icon: FC<Props> = ({name, color = primary.main, size = 16, ...props}) => { | ||
if (!name) { | ||
return null; | ||
} | ||
return <IconComponent name={name} color={color} size={size} {...props} />; | ||
}; | ||
|
||
export default Icon; |
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Estuve viendo el storybook-web pero no se están viendo los iconos, estuve probando un par de cosas y puede ser que porque cuándo se generan los archivos de .storybook_static, en el iframe.html queda la ubicación de '../assets/public/janis-font-icon.ttf'.
Me parece que lo mejor sería agregar la propiedad
staticDirs: ['../src/fonts'],
dentro del main.js de .storybook, esto hace que cuándo se generen los archivos de storybook-web, también se van a estar agregando las fuentes custom que tengamos en esa carpeta fontsY también modificar el preview-head.html para que, en vez de estar tomando ../assets/public/janis-font-icon.ttf cómo lo está haciendo, tome ../janis-font-icon.ttf. Igualmente probé y todavía no están apareciendo los iconos en web, pero me parece que por ese lado se podría encarar.