Merge branch 'JMV-2958-crear-nuevas-actions' of https://github.com/ja…

…nis-commerce/view-schema-validator into JMV-2958-crear-nuevas-actions
janis-commerce · May 18, 2023 · 8fb0118 · 8fb0118
2 parents 01ff59c + 0011d1c
commit 8fb0118
Show file tree

Hide file tree

Showing 5 changed files with 59 additions and 36 deletions.
diff --git a/lib/deprecation-validators/index.js b/lib/deprecation-validators/index.js
@@ -4,10 +4,12 @@ const title = require('./title-deprecation');
 const titleComponents = require('./title-components-deprecation');
 const staticFilters = require('./static-filters-deprecation');
 const pathQuery = require('./path-query-deprecation');
+const remoteAction = require('./remoteActions-deprecation');
 
 module.exports = {
 	title,
 	titleComponents,
 	staticFilters,
-	pathQuery
+	pathQuery,
+	remoteAction
 };
diff --git a/lib/deprecation-validators/remoteActions-deprecation.js b/lib/deprecation-validators/remoteActions-deprecation.js
@@ -0,0 +1,21 @@
+'use strict';
+
+const { getDaysToRemoveFeatureMessage, isEdit } = require('../helpers');
+
+module.exports = class RemoteActionsDeprecation {
+
+	static getDayToRemove() {
+		return '07/15/2023';
+	}
+
+	static getDeprecatedMessage() {
+
+		return `The property \`remoteActions\` is going to be deprecated. ${getDaysToRemoveFeatureMessage(this.getDayToRemove())}`;
+	}
+
+	static validate(schema) {
+
+		if(isEdit(schema))
+			return JSON.stringify(schema).indexOf('remoteActions') === -1;
+	}
+};
diff --git a/lib/schemas/common/actions.js b/lib/schemas/common/actions.js
@@ -22,7 +22,7 @@ module.exports = ({
 		},
 		{
 			required: [
-				'source', 'sourceEndpointParameters'
+				'source'
 			]
 		}
 	],

diff --git a/tests/mocks/schemas/edit-with-actions.yml b/tests/mocks/schemas/edit-with-actions.yml
@@ -91,7 +91,7 @@ actions:
     resolve: false
   sourceEndpointParameters:
     - name: status
-      target: query
+      target: queryString
       value:
         static: active
   staticActions:
@@ -167,7 +167,7 @@ sections:
                 value:
                   dynamic: id
               - name: status
-                target: query
+                target: queryString
                 value:
                   static: active
             targetField: fieldNameThree
@@ -260,7 +260,7 @@ sections:
                   value:
                     dynamic: id
                 - name: status
-                  target: query
+                  target: queryString
                   value:
                     static: 1
 
@@ -599,7 +599,7 @@ sections:
                   value:
                     dynamic: id
                 - name: status
-                  target: query
+                  target: queryString
                   value:
                     static: 1
 
@@ -786,7 +786,7 @@ sections:
                   value:
                     dynamic: id
                 - name: status
-                  target: query
+                  target: queryString
                   value:
                     static: 1
               source:
@@ -805,7 +805,7 @@ sections:
             componentAttributes:
               endpointParameters:
                 - name: id
-                  target: query
+                  target: queryString
                   value:
                     dynamic: userIds
               source:
@@ -853,7 +853,7 @@ sections:
                   value:
                     dynamic: id
                 - name: status
-                  target: query
+                  target: queryString
                   value:
                     static: 1
 
@@ -871,7 +871,7 @@ sections:
                     value:
                       dynamic: id
                   - name: status
-                    target: query
+                    target: queryString
                     value:
                       static: 1
                 dataMapping:
@@ -1023,7 +1023,7 @@ sections:
                     value:
                       dynamic: id
                   - name: status
-                    target: query
+                    target: queryString
                     value:
                       static: 1
                 valuesMapper:
@@ -1112,7 +1112,7 @@ sections:
                     value:
                       dynamic: id
                   - name: status
-                    target: query
+                    target: queryString
                     value:
                       static: 1
                 valuesMapper:
@@ -1377,11 +1377,11 @@ sections:
         value:
           dynamic: statusId
       - name: status
-        target: query
+        target: queryString
         value:
           static: 1
       - name: status
-        target: query
+        target: queryString
         value:
           static:
             id: "string"
@@ -1538,7 +1538,7 @@ sections:
         value:
           dynamic: statusId
       - name: status
-        target: query
+        target: queryString
         value:
           static: 1
     filesTypes:
@@ -1561,11 +1561,11 @@ sections:
         value:
           dynamic: statusId
       - name: status
-        target: query
+        target: queryString
         value:
           static: 1
       - name: status
-        target: query
+        target: queryString
         value:
           static:
             id: string
@@ -1630,7 +1630,7 @@ sections:
         value:
           dynamic: id
       - name: status
-        target: query
+        target: queryString
         value:
           static: 1
     includeDataFrom:
@@ -1858,7 +1858,7 @@ sections:
                 value:
                   dynamic: id
               - name: status
-                target: query
+                target: queryString
                 value:
                   static: 1
       - name: stepsExample

diff --git a/tests/mocks/schemas/expected/edit-with-actions.json b/tests/mocks/schemas/expected/edit-with-actions.json
@@ -142,7 +142,7 @@
 		"sourceEndpointParameters": [
 			{
 				"name": "status",
-				"target": "query",
+				"target": "queryString",
 				"value": {
 					"static": "active"
 				}
@@ -260,7 +260,7 @@
 								},
 								{
 									"name": "status",
-									"target": "query",
+									"target": "queryString",
 									"value": {
 										"static": "active"
 									}
@@ -400,7 +400,7 @@
 									},
 									{
 										"name": "status",
-										"target": "query",
+										"target": "queryString",
 										"value": {
 											"static": 1
 										}
@@ -949,7 +949,7 @@
 									},
 									{
 										"name": "status",
-										"target": "query",
+										"target": "queryString",
 										"value": {
 											"static": 1
 										}
@@ -1251,7 +1251,7 @@
 									},
 									{
 										"name": "status",
-										"target": "query",
+										"target": "queryString",
 										"value": {
 											"static": 1
 										}
@@ -1280,7 +1280,7 @@
 								"endpointParameters": [
 									{
 										"name": "id",
-										"target": "query",
+										"target": "queryString",
 										"value": {
 											"dynamic": "userIds"
 										}
@@ -1349,7 +1349,7 @@
 									},
 									{
 										"name": "status",
-										"target": "query",
+										"target": "queryString",
 										"value": {
 											"static": 1
 										}
@@ -1379,7 +1379,7 @@
 										},
 										{
 											"name": "status",
-											"target": "query",
+											"target": "queryString",
 											"value": {
 												"static": 1
 											}
@@ -1608,7 +1608,7 @@
 										},
 										{
 											"name": "status",
-											"target": "query",
+											"target": "queryString",
 											"value": {
 												"static": 1
 											}
@@ -1735,7 +1735,7 @@
 										},
 										{
 											"name": "status",
-											"target": "query",
+											"target": "queryString",
 											"value": {
 												"static": 1
 											}
@@ -2081,14 +2081,14 @@
 				},
 				{
 					"name": "status",
-					"target": "query",
+					"target": "queryString",
 					"value": {
 						"static": 1
 					}
 				},
 				{
 					"name": "status",
-					"target": "query",
+					"target": "queryString",
 					"value": {
 						"static": {
 							"id": "string"
@@ -2424,7 +2424,7 @@
 				},
 				{
 					"name": "status",
-					"target": "query",
+					"target": "queryString",
 					"value": {
 						"static": 1
 					}
@@ -2453,14 +2453,14 @@
 				},
 				{
 					"name": "status",
-					"target": "query",
+					"target": "queryString",
 					"value": {
 						"static": 1
 					}
 				},
 				{
 					"name": "status",
-					"target": "query",
+					"target": "queryString",
 					"value": {
 						"static": {
 							"id": "string"
@@ -2547,7 +2547,7 @@
 				},
 				{
 					"name": "status",
-					"target": "query",
+					"target": "queryString",
 					"value": {
 						"static": 1
 					}
@@ -2943,7 +2943,7 @@
 								},
 								{
 									"name": "status",
-									"target": "query",
+									"target": "queryString",
 									"value": {
 										"static": 1
 									}